Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7966: Ibexa Engage described in User Documentation #296

Merged
merged 18 commits into from
Jul 2, 2024

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented May 16, 2024

Question Answer
JIRA Ticket IBX-8268
Versions master
Edition Experience, Commerce

Preview: https://ez-systems-developer-documentation--296.com.readthedocs.build/projects/userguide/en/296/ibexa_engage/ibexa_engage/

Developer PR: ibexa/documentation-developer#2339

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

@radzyu radzyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julitafalcondusza I've added comments to selected sections.
There is also some general remark related to navigation and order of sections in the User guide.
Together with @SylvainGuittard we think it’s confusing, not consistent with product versions, backoffice menu. Our suggestion:

  • PIM should be after Content management (not at the bottom under Commerce and Perso) - firstly you need to create products, to later sell them online using Commerce :)
  • Commerce should be above Perso (Perso is add-on, not core product/capability)
  • Customer management and Website organization - @SylvainGuittard where will you put these sections, what's your suggestion?
    It could be addressed in a separate ticket/PR.

docs/ibexa_engage/ibexa_engage.md Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
@julitafalcondusza
Copy link
Contributor Author

@radzyu - regarding your comment about navigation/ToC reorganization - this needs to be addressed in separate ticket/PR.

@radzyu
Copy link

radzyu commented Jun 4, 2024

@radzyu - regarding your comment about navigation/ToC reorganization - this needs to be addressed in separate ticket/PR.

@julitafalcondusza Could you create this ticket and move these remarks/requested changes

Copy link

@radzyu radzyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added additional comments to selected sentences and screens.

@julitafalcondusza julitafalcondusza requested a review from radzyu June 4, 2024 10:28
Copy link

@radzyu radzyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment/change: 845f59a#r142807053

docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/img/campaign_custom_tag.png Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/content_management/block_reference.md Outdated Show resolved Hide resolved
docs/content_management/block_reference.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
docs/ibexa_engage/ibexa_engage.md Outdated Show resolved Hide resolved
@julitafalcondusza julitafalcondusza requested a review from dabrt June 14, 2024 11:33
Copy link

sonarqubecloud bot commented Jul 2, 2024

@julitafalcondusza julitafalcondusza merged commit 16a0067 into master Jul 2, 2024
5 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-7966 branch July 2, 2024 06:56
julitafalcondusza added a commit that referenced this pull request Jul 2, 2024
* Qualifio block added in block reference

* Name updated, order correction

* Content added

* typo fix

* note added

* sentence added

* Fixes

* Screenshots added, content updated

* Sentence added, fixes

* Fixes

* Fix

* Sentence added

* Content updated

* Caption updated

* Fix in order of blocks

* Fixes after doc review

* Fixes after doc review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants